docs(ocf): record VD-role server-authenticated findings - #60
Merged
Conversation
Add docs/ocf-vd-devices.md: sanitized results for a HW-S61B soundbar (VD-NetworkAudio-002S) and a KANTSU2-family television (VD-STV_2018_K) over SamsungServerProfile/ServerCertificateAuth with the VD_DEVICE role. Includes the 64/67-link /oic/res directories reduced to safe fields, redacted doxm/pstat state, and the 4.01 authorization boundary. Raw captures with device identifiers are deliberately excluded.
Owner
|
The share-safety failure is a bug in my checker. Thanks for adding. |
mbillow
pushed a commit
to mbillow/SmartThings-Local
that referenced
this pull request
Aug 23, 2026
IPV6_RE allows empty hex groups, so a C++ or Rust scope operator preceded by a hex letter matches: TbsCertificate::signature_alg yields "e::", which ipaddress parses as a valid address in the all-zero reserved block. QuiteYellow#60 fails share-safety on exactly that line. _safe_ipv6 now also accepts an address in an IETF-reserved block. Those are not assignable to a host, so they cannot be the leak this rule exists to catch, while global unicast, link-local and unique-local stay flagged and cover every real case. Tightening the regex instead would drop link-local addresses, which are the ones that leak out of captures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs/ocf-vd-devices.md: sanitized results for a HW-S61B soundbar (VD-NetworkAudio-002S) and a KANTSU2-family television (VD-STV_2018_K) over SamsungServerProfile/ServerCertificateAuth with the VD_DEVICE role. Includes the 64/67-link /oic/res directories reduced to safe fields, redacted doxm/pstat state, and the 4.01 authorization boundary. Raw captures with device identifiers are deliberately excluded.