Skip to content

fix(storage): ensure monotonic ID ordering for sql query history list and batch prune #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Aug 26, 2026
+6 −3
Merged

fix(storage): ensure monotonic ID ordering for sql query history list and batch prune #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/core/storage/local_db.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class LocalDb {
'''
SELECT id FROM sql_query_history
WHERE connection_id = ? AND database_name IS NOT DISTINCT FROM ?
ORDER BY recorded_at ASC, id ASC
ORDER BY id ASC
LIMIT ?
''',
[connectionId, databaseName, excess],
Expand Down Expand Up @@ -340,7 +340,7 @@ class LocalDb {
SELECT id, connection_id, database_name, sql_text, recorded_at
FROM sql_query_history
WHERE connection_id = ? AND database_name IS NOT DISTINCT FROM ?
ORDER BY recorded_at DESC, id DESC
ORDER BY id DESC
LIMIT ?
''',
[connectionId, dbKey, limit],
Expand All @@ -350,6 +350,7 @@ class LocalDb {

/// Removes all history rows for [connectionId] (every database bucket).
Future<void> clearSqlQueryHistoryForConnection(int connectionId) async {
_historyInsertCounts.removeWhere((k, _) => k.startsWith('$connectionId::'));
final db = await _open();
await db.delete(
'sql_query_history',
Expand All @@ -363,8 +364,9 @@ class LocalDb {
required int connectionId,
String? databaseName,
}) async {
final db = await _open();
final dbKey = _normalizeHistoryDatabaseName(databaseName);
_historyInsertCounts.remove('$connectionId::${dbKey ?? ''}');
final db = await _open();
await db.rawDelete(
'''
DELETE FROM sql_query_history
Expand Down Expand Up @@ -524,6 +526,7 @@ class LocalDb {
/// Deletes a connection. SQLite deletion always proceeds even if the secure
/// store delete fails (e.g. missing key or unavailable libsecret daemon).
Future<void> removeConnection(int id) async {
_historyInsertCounts.removeWhere((k, _) => k.startsWith('$id::'));
try {
await ConnectionSecretsStore.deleteForConnection(id);
} catch (_) {
Expand Down
Loading