Skip to content

feat(a11y): add explicit FocusTraversalGroup to multi-section connection dialogs (#610) #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 2 commits into from
Aug 26, 2026
Merged

feat(a11y): add explicit FocusTraversalGroup to multi-section connection dialogs (#610) #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc2cda
feat(a11y): add explicit FocusTraversalGroup to multi-section connect…
ZhuchkaTriplesix Aug 26, 2026
a8b0706
fix(test): remove unused import in connection_dialog_focus_traversal_…
ZhuchkaTriplesix Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions lib/core/sdui/sdui_form_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,21 +145,24 @@ class SduiFormBuilderState extends material.State<SduiFormBuilder> {

@override
material.Widget build(material.BuildContext context) {
return material.Form(
key: _formKey,
child: material.Column(
crossAxisAlignment: material.CrossAxisAlignment.stretch,
mainAxisSize: material.MainAxisSize.min,
children: [
if (widget.schema.title != null) ...[
Text(widget.schema.title!).large().semiBold(),
const Gap(12),
],
for (var i = 0; i < widget.schema.fields.length; i++) ...[
if (i > 0) const Gap(12),
_buildField(widget.schema.fields[i]),
return material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
child: material.Form(
key: _formKey,
child: material.Column(
crossAxisAlignment: material.CrossAxisAlignment.stretch,
mainAxisSize: material.MainAxisSize.min,
children: [
if (widget.schema.title != null) ...[
Text(widget.schema.title!).large().semiBold(),
const Gap(12),
],
for (var i = 0; i < widget.schema.fields.length; i++) ...[
if (i > 0) const Gap(12),
_buildField(widget.schema.fields[i]),
],
],
],
),
),
);
}
Expand Down
171 changes: 90 additions & 81 deletions lib/features/connections/extension_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,12 @@ class _ExtensionConnectionFormContentState
minWidth: 440,
),
borderColor: theme.muted,
child: material.Column(
mainAxisSize: material.MainAxisSize.min,
crossAxisAlignment: material.CrossAxisAlignment.stretch,
children: [
child: material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
child: material.Column(
mainAxisSize: material.MainAxisSize.min,
crossAxisAlignment: material.CrossAxisAlignment.stretch,
children: [
material.Padding(
padding: const material.EdgeInsets.fromLTRB(24, 24, 24, 8),
child: material.Column(
Expand All @@ -218,96 +220,103 @@ class _ExtensionConnectionFormContentState
),
),
material.Flexible(
child: material.SingleChildScrollView(
padding: const material.EdgeInsets.fromLTRB(24, 8, 24, 8),
child: material.Column(
crossAxisAlignment: material.CrossAxisAlignment.stretch,
children: [
const Text('Connection name').small().muted(),
const material.SizedBox(height: 4),
TextField(
controller: _nameController,
placeholder: const Text('My ClickHouse'),
),
const material.SizedBox(height: 16),
if (_loading)
const material.Padding(
padding: material.EdgeInsets.all(24),
child: material.Center(
child: material.CircularProgressIndicator(),
),
)
else if (_loadError != null)
Text(_loadError!).muted().small()
else if (_schema != null)
SduiFormBuilder(
key: _formKey,
schema: _schema!,
initialValues: _initialValues,
keepExistingSecrets: _isEditing,
child: material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
child: material.SingleChildScrollView(
padding: const material.EdgeInsets.fromLTRB(24, 8, 24, 8),
child: material.Column(
crossAxisAlignment: material.CrossAxisAlignment.stretch,
children: [
const Text('Connection name').small().muted(),
const material.SizedBox(height: 4),
TextField(
controller: _nameController,
placeholder: const Text('My ClickHouse'),
),
if (_testMessage != null) ...[
const material.SizedBox(height: 12),
material.SelectableText(
_testMessage!,
style: material.TextStyle(
fontSize: 12,
color: _testSucceeded
? material.Colors.green
: theme.destructive,
const material.SizedBox(height: 16),
if (_loading)
const material.Padding(
padding: material.EdgeInsets.all(24),
child: material.Center(
child: material.CircularProgressIndicator(),
),
)
else if (_loadError != null)
Text(_loadError!).muted().small()
else if (_schema != null)
SduiFormBuilder(
key: _formKey,
schema: _schema!,
initialValues: _initialValues,
keepExistingSecrets: _isEditing,
),
),
if (_testMessage != null) ...[
const material.SizedBox(height: 12),
material.SelectableText(
_testMessage!,
style: material.TextStyle(
fontSize: 12,
color: _testSucceeded
? material.Colors.green
: theme.destructive,
),
),
],
],
],
),
),
),
),
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24,
vertical: 16,
),
decoration: material.BoxDecoration(
border: material.Border(
top: material.BorderSide(
color: theme.border.withValues(alpha: 0.3),
material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
child: material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24,
vertical: 16,
),
decoration: material.BoxDecoration(
border: material.Border(
top: material.BorderSide(
color: theme.border.withValues(alpha: 0.3),
),
),
),
),
child: material.Row(
children: [
OutlineButton(
onPressed:
_schema == null || _testing ? null : _testConnection,
leading: _testing
? const material.SizedBox(
width: 14,
height: 14,
child: material.CircularProgressIndicator(
strokeWidth: 2,
child: material.Row(
children: [
OutlineButton(
onPressed:
_schema == null || _testing ? null : _testConnection,
leading: _testing
? const material.SizedBox(
width: 14,
height: 14,
child: material.CircularProgressIndicator(
strokeWidth: 2,
),
)
: const material.Icon(
material.Icons.bolt_rounded,
size: 16,
),
)
: const material.Icon(
material.Icons.bolt_rounded,
size: 16,
),
child: const Text('Test Connection'),
),
const Spacer(),
GhostButton(
onPressed: () => material.Navigator.of(context).pop(),
child: const Text('Cancel'),
),
const material.SizedBox(width: 12),
PrimaryButton(
onPressed: _schema == null ? null : _save,
child: const Text('Save'),
),
],
child: const Text('Test Connection'),
),
const Spacer(),
GhostButton(
onPressed: () => material.Navigator.of(context).pop(),
child: const Text('Cancel'),
),
const material.SizedBox(width: 12),
PrimaryButton(
onPressed: _schema == null ? null : _save,
child: const Text('Save'),
),
],
),
),
),
],
),
),
);
}
}
Expand Down
Loading
Loading