perf(params): zero-allocation path parameter extraction from URL slices (#140) - #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
match_route_compiledandmatch_ws_route_compiledinsrc/state.rsto return borrowedmatchit::Params<'a, 'b>slices directly instead of allocating intermediate heapVec<(String, String)>and ownedStrings.run_rsgiinsrc/dispatch.rsto iterate overparams.iter()directly when populating kwargs into the PythonPyDict.value_for_path_paraminsrc/params.rsto createPyStringdirectly from&strslices without allocating intermediate RustStrings.