Public proof agg

[illuzen]

Summary

Wires the new second-layer ("public batch") wormhole aggregation into the CLI so the
full flow — leaf proofs → private batches → public batch → on-chain verification with
aggregator fee rebate — can be exercised end to end against a dev node.

Changes

New / extended commands

• wormhole aggregate-public: aggregates private-batch proof files into a single
  public-batch proof, embedding the wallet's address as the aggregator_address
  (partial batches are padded with dummies automatically).
• wormhole verify-public-batch: submits a public-batch proof via the unsigned
  verify_public_batch extrinsic and reports the resulting events, including the
  aggregator rebate.
• wormhole parse-proof --public-batch: parses and pretty-prints public-batch
  public inputs (aggregator address, header, per-segment exit slots and nullifiers).
• wormhole multiround --public: extends the existing end-to-end test command to
  run the complete public-batch flow — generate leaf proofs, aggregate into private
  batches, aggregate those into a public batch (wallet as aggregator), submit, and
  verify balances/events.

Terminology and bindings

• Renamed to private-batch / public-batch terminology throughout, matching the
  circuits repo (verify_aggregated_proof → verify_private_batch).
• Regenerated subxt bindings and embedded metadata (quantus_subxt.rs,
  quantus_metadata.scale) against the updated runtime with verify_public_batch.

Build / infra

• build.rs and src/bins.rs generate and validate public-batch circuit binaries;
  branching factor configurable via QP_NUM_PRIVATE_BATCH_PROOFS
  (default DEFAULT_NUM_PRIVATE_BATCH_PROOFS = 4, matching the pallet).
• [patch.crates-io] temporarily points the qp-wormhole-* /
  qp-zk-circuits-common crates at the local ../qp-zk-circuits checkout.
  Must be switched to published crate versions before merge.

Test plan

• cargo build --release compiles cleanly.
• Against a --dev node built from the companion chain PR:
  • quantus wormhole multiround (private-batch flow, regression) passes.
  • quantus wormhole multiround --public completes the full public-batch flow;
    events show segment mints and the aggregator rebate credited to the wallet.
• quantus exercise wormhole scenario still compiles and runs (updated for the
  new --public flag).

---

Note

High Risk
Changes ZK circuit binaries and wormhole verification artifact names that must stay in sync with chain pallet defaults; the temporary [patch.crates-io] path breaks builds/CI without a sibling circuits repo.

Overview
Aligns wormhole aggregated proof naming and artifacts with private-batch / public-batch circuits: SDK examples and docs call verify_private_batch_and_get_events instead of the old aggregated helpers, and build-circuits / chain copy steps reference private_batch_* binaries (not aggregated_*).

Circuit generation now takes QP_NUM_PRIVATE_BATCH_PROOFS (default 4, matching the pallet) alongside leaf count. build.rs and runtime bins require private and public batch prover/verifier/common bins plus dummy_private_batch_proof.bin, and config.json readiness checks accept num_private_batch_proofs (with num_layer0_proofs alias). [patch.crates-io] temporarily points qp-wormhole-* at a local ../qp-zk-circuits checkout until published 3.1.0; Cargo.lock drops crates.io checksums for those patched packages.

Adds a nightly / manual GitHub workflow that builds quantus-node (fast-governance) from Quantus-Network/chain, starts a dev node, and runs quantus exercise --json with artifact upload.

^{Reviewed by Cursor Bugbot for commit c6fadf8. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit c6fadf8. Configure here.}

[cursor]

CLI version not bumped

Medium Severity

The crate version stays at 1.5.0 while this change adds public-batch circuit parameters (DEFAULT_NUM_PRIVATE_BATCH_PROOFS), new required bin artifacts, and [patch.crates-io] overrides for the wormhole circuit crates. Without a CLI version bump, is_ready()’s .quantus-cli-version marker can still match for installs that already had 1.5.0 but stale generated bins from an earlier build with the same version string.

Additional Locations (2)

• src/bins_consts.rs#L16-L21
• src/bins.rs#L25-L40

 

^{Triggered by learned rule: Bump CLI version when proof system parameters or circuit crate versions change}

^{Reviewed by Cursor Bugbot for commit c6fadf8. Configure here.}

[cursor]

Exercise CI missing circuits checkout

High Severity

The new Chain Exercise workflow checks out only quantus-cli and chain, then runs cargo build --release --locked. The same commit adds [patch.crates-io] entries pointing at ../qp-zk-circuits/..., which is not present on the runner, so dependency resolution fails before the suite can run.

Additional Locations (1)

• Cargo.toml#L124-L133

 

^{Reviewed by Cursor Bugbot for commit c6fadf8. Configure here.}