Re: pos mode update#486
Merged
Merged
Conversation
- comply with hasura syntax - change to new graphql url in constants - update data model construction from json to comply new hasura return value
We have made hasura return string for number value.
- Delete unused assets - Delete unused widgets
- finish input charge screen - finish scan to pay screen
…into beast/update-graphql
…work/quantus-apps into beast/miner-reward-menu
change toHash to to_hash
…work/quantus-apps into beast/miner-reward-menu
…Network/quantus-apps into beast/cleanup-unused-files
…us-Network/quantus-apps into beast/pos-mode-update
…into beast/miner-reward-menu
Rewrites Skeleton to use theme-aware skeletonHighlightA/B colors, extracts TxItemSkeleton as a standalone widget, and converts skeletonHighlight to two-stop skeletonHighlightA/B in AppColorsV2. Co-authored-by: Cursor <cursoragent@cursor.com>
…-update) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…into feat/skeleton-widget-update
…tus-Network/quantus-apps into beast/cleanup-unused-files
…us-Network/quantus-apps into beast/pos-mode-update
…into beast/pos-mode-update
…into beast/pos-mode-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already approved this branch but I forgot to switch to main for target branch in this PR #479
Note
Medium Risk
Moderate risk because it rewires POS amount parsing/fiat toggling and updates the payment-received flow/UI, which could impact charge amounts and transaction watching behavior if edge cases slip through.
Overview
Introduces shared
AmountInputLogic(with unit tests) to centralize QUAN↔fiat parsing/formatting and ensure toggle behavior keeps displayed text and underlyingBigIntamount in sync.Revamps POS mode UX:
PosAmountScreenmoves from a custom keypad to a locale-awareTextFieldwith fiat/QUAN flip, andHomeScreenchanges POS entry to a bottom “Charge” action (removing the stacked “New Charge” button overlay).Unifies QR rendering via new
QuantusQrcomponent (used in Receive + POS), and significantly updatesPosQrScreenwith improved waiting/error states plus a richer “Payment Received” view (timestamp, sender checkphrase/address, explorer link, and Done/New Charge actions). Also removes unused SVG assets and does a small formatting-only change inSettingsService.Reviewed by Cursor Bugbot for commit 48046df. Bugbot is set up for automated code reviews on this repo. Configure here.