Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
5572080 to
1990b05
Compare
Member
Author
|
|
Jutho
reviewed
Apr 28, 2026
| end | ||
| @eval function MAK.$remove_f_gauge_dependence!(ΔV::AbstractTensorMap, D, V, inds; kwargs...) | ||
| foreachblock(ΔV, D, V) do c, (Δv, d, v) | ||
| haskey(inds, c) || return nothing |
Member
There was a problem hiding this comment.
I assume that if !haskey(inds, c), then indeed ΔV doesn't have such a block either and Δv is just an empty matrix? But due to the fact that a c block can exist in V and D and the union semantics of foreachblock, such c would still be generated by the iterator.
Member
Author
There was a problem hiding this comment.
Yes, although actually in the current implementation this never happens since all sectors are always present in the inds that come from the truncation implementations, possibly with inds[c] empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After MatrixAlgebraKit v0.6.6, these functions are now simply overloaded and the block implementation can be re-used