Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Jutho
reviewed
Mar 13, 2026
borisdevos
changed the title
Member
|
hoping that the merge commit will fix the faulty actions as well... |
Jutho
reviewed
Apr 21, 2026
Jutho
previously approved these changes
Apr 21, 2026
Member
Author
|
Compat check is still failing so I can't merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR achieves multiple things:
A4Irrep, currently the only available sector type in TensorKitSectors withGenericFusion.ZNElementsector types which haveUniqueFusionbut non-trivial F-symbols, revealing an error infoldright.I started on this a while ago, but refrained from progressing because #261 seemed to be picking up speed, but since then it's remained unmerged, so I thought to just finish this and not have to worry about some of the issues we knew were present.
Edit: after #261 and #389 this PR does less than summed above :)