Fix FixedSpaceTruncation for simple update#360
Open
Yue-Zhengyuan wants to merge 13 commits intoQuantumKitHub:masterfrom
Open
Fix FixedSpaceTruncation for simple update#360Yue-Zhengyuan wants to merge 13 commits intoQuantumKitHub:masterfrom
Yue-Zhengyuan wants to merge 13 commits intoQuantumKitHub:masterfrom
Conversation
Yue-Zhengyuan
added a commit
to Yue-Zhengyuan/PEPSKit.jl
that referenced
this pull request
Apr 17, 2026
Member
Author
|
Just realized that |
Contributor
sanderdemeyer
left a comment
sanderdemeyer
left a comment
There was a problem hiding this comment.
Apart from the 2 small comments above, this looks good to me.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes
FixedSpaceTruncationfor Simple Update, which was broken after generalizing it for arbitrary MPO gates in #339. This introduces some breaking changes forSiteDependentTruncationas well:truncs[1, :, :]now refers to horizontal (instead of NORTH/vertical) truncations, following the convention ofSUWeight.For bipartite state tests, I refactored the function
_is_bipartitethat checks whether the input object matches the bipartite lattice structure.Finally, in SU for the ground state, I now also output the energy estimated with SUWeight (equivalently BPEnv). But convergence is still determined from the change in SUWeight (instead of energy).