Add GPU-safe index selection for eig/eigh pullbacks - #273
Merged
Conversation
kshyatt
force-pushed
the
ksh/select-indices
branch
from
August 18, 2026 11:25
29dc1a7 to
b3a1b30
Compare
Member
Author
|
Blocked on #272 but this seems to work!!! |
kshyatt
marked this pull request as ready for review
August 18, 2026 12:44
kshyatt
force-pushed
the
ksh/select-indices
branch
from
August 19, 2026 13:06
b3a1b30 to
0b13690
Compare
kshyatt
force-pushed
the
ksh/select-indices
branch
from
August 20, 2026 12:18
0b13690 to
e48ab96
Compare
Member
|
This looks like a nice solution. |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this removes the need to copy back for the PB steps