Update MatrixAlgebraKit algorithm specification#418
Open
Conversation
Member
Author
|
CUDA tests are failing, but I see the same failure on The issue seems to be that calling left_orth!(t::TensorKit.TensorMap{ComplexF64, TensorKit.ComplexSpace, 2, 4, CUDA.CuArray{ComplexF64, 1, CUDA.DeviceMemory}}; trunc::MatrixAlgebraKit.TruncationByValue{Float64, Int64, typeof(abs)})with only a left_orth!(A::TensorKit.TensorMap{ComplexF64, TensorKit.ComplexSpace, 2, 4, CUDA.CuArray{ComplexF64, 1, CUDA.DeviceMemory}}, VC::Nothing, alg::MatrixAlgebraKit.LeftOrthAlgorithm{:svd, MatrixAlgebraKit.TruncatedAlgorithm{MatrixAlgebraKit.SafeDivideAndConquer{@NamedTuple{}}, MatrixAlgebraKit.TruncationByValue{Float64, Int64, typeof(abs)}}})with an explicit This seems like a problem with the algorithm selection not properly taking into account the storagetype in MatrixAlgebraKit.jl/TensorKit.jl? I can open an issue, but not really sure which one of the two is giving the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the decomposition algorithm specification for the changes of MatrixAlgebraKit.jl v0.6.5.
For the SVD algorithm I set
DefaultAlgorithmas the default, since that should just pick the best option regardless of the storage type. For the QR algorithm I couldn't do that because of QuantumKitHub/TensorKit.jl#405, so there I explicitly set it toHouseHolder(; positive = true).