[theil_2.md] Update np.random → Generator API#1005
Open
Chihiro2000GitHub wants to merge 1 commit into
Open
Conversation
56 tasks
📖 Netlify Preview Ready!Preview URL: https://pr-1005--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates legacy NumPy random API usage in
theil_2.mdas part of QuantEcon/meta#299.The seeded
np.random.seed(...)/np.random.randn(...)pattern in the cell that plots standard against robust consumption paths is replaced with an explicit seeded generatorrng = np.random.default_rng(0).Related PRs and issues
I checked for open PRs and issues related to this lecture. No open PR modifies
theil_2.md. Issue #990 liststheil_2.mdamong the lectures with dangling citation keys, but the fix there is toquant-econ.bibrather than to this file, and this PR does not attempt to address it.Details
np.random.seed(0)→rng = np.random.default_rng(0), andnp.random.randn(T_sim - 1)→rng.standard_normal(T_sim - 1).0) is kept, andrngis local to the cell that uses it, so no hidden global random state remains.shock_path, so the comparison between the standard and robust policies is unaffected.np.random, and it describes the paths qualitatively rather than by their realized values.@jit,@njit,@jitclass,parallel=True,prange) code.theil_2.mdexecuted without errors.Note for reviewers
The figure changes:
default_rngdraws from a different stream than the legacy API, so the same seed gives different draws. The rebuilt figure shows the same pattern as the current one.Hi @mmcky and @HumphreyYang, I'd be grateful if you could take a look when you have time.