FIX: assert the sparse-Q equality check in test_ddp.py - #908
Open
Sanjays2402 wants to merge 2 commits into
Open
Conversation
The sparse transition-array comparison in test_ddp_to_sa_and_to_product computed a boolean and discarded it, so the check never verified anything: a wrong converted Q would not fail the test. Add the missing assert (and fix the adjacent 'allcose' typo). The assertion passes on the current conversion code; feeding it a deliberately wrong Q raises AssertionError. Closes QuantEcon#874
oyamad
requested changes
Jul 26, 2026
Author
|
Applied, thanks - switched to |
|
coverage: 90.546% (-3.2%) from 93.725% — Sanjays2402:fix/ddp-sparse-q-missing-assert into QuantEcon:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874
The sparse-Q comparison in
test_ddp_to_sa_and_to_productcomputed a boolean and threw it away, so that check has never verified anything — a wrong convertedQwould pass silently. This adds the missingassert(and fixes the adjacentallcosetypo).The assertion passes against the current conversion code; substituting a deliberately wrong
Qinto the same expression raisesAssertionError, confirming it now guards.pytest quantecon/markov/tests/test_ddp.pyis green (20 passed).