FIX: fetch_nb_dependencies must not save HTTP error pages - #904
Open
Sanjays2402 wants to merge 1 commit into
Open
FIX: fetch_nb_dependencies must not save HTTP error pages#904Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
fetch_nb_dependencies wrote whatever the server returned straight to disk and appended True to the status list, so a request for a missing remote file saved GitHub's HTML error page under the requested filename and reported it as fetched. The failure only surfaced later as a parse error in unrelated code. - call raise_for_status() and append False on any RequestException instead of writing the response body - add a default request timeout, overridable via the timeout keyword - stop rebinding the loop variable to the open file handle - accept a tuple of filenames via isinstance instead of type(..) == list Closes QuantEcon#870
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
fetch_nb_dependencieswrote whatever the server returned straight to disk and appendedTrueto the status list, so requesting a file that does not exist remotely saved GitHub's HTML error page under the requested filename and reported it as fetched — surfacing later as a parse error in unrelated code.This calls
raise_for_status()and appendsFalseon anyRequestExceptioninstead of writing the body, adds a default requesttimeout(overridable by keyword), stops rebinding the loop variable to the open file handle, and accepts a tuple viaisinstancerather thantype(files) == list.Three regression tests in
TestFetchNbDependenciesErrorscover the three behaviours; all three fail against the original source (error page written,timeoutrejected as an unexpected kwarg, tuple raisingAttributeError: 'tuple' object has no attribute 'keys') and pass with the fix. The two existing network tests are untouched.