Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion QuiverCNBC.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public override BaseData Reader(SubscriptionDataConfig config, string line, Date
{
Symbol = config.Symbol,
Time = uploadedDate.AddDays(-1),
AdviceDate = (csv[1].IfNotNullOrEmpty<DateTime?>(s => Parse.DateTimeExact(s, "yyyyMMdd")) ?? uploadedDate).AddDays(-1),
AdviceDate = csv[1].IfNotNullOrEmpty<DateTime?>(s => Parse.DateTimeExact(s, "yyyyMMdd")) ?? uploadedDate.AddDays(-1),
Direction = QuiverQuant.QuiverQuantCsvExtensions.ToOrderDirection(csv[2]),
Traders = csv[3],
Notes = csv.Length > 4 ? csv[4] : string.Empty,
Expand Down
2 changes: 1 addition & 1 deletion QuiverCNBCsUniverse.cs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public override BaseData Reader(SubscriptionDataConfig config, string line, Date
{
Symbol = new Symbol(SecurityIdentifier.Parse(csv[0]), csv[1]),
Time = date.AddDays(-1),
AdviceDate = (csv[2].IfNotNullOrEmpty<DateTime?>(s => Parse.DateTimeExact(s, "yyyyMMdd")) ?? date).AddDays(-1),
AdviceDate = csv[2].IfNotNullOrEmpty<DateTime?>(s => Parse.DateTimeExact(s, "yyyyMMdd")) ?? date.AddDays(-1),
Direction = QuiverQuant.QuiverQuantCsvExtensions.ToOrderDirection(csv[3]),
Traders = csv[4],
Notes = csv.Length > 5 ? csv[5] : string.Empty,
Expand Down
17 changes: 15 additions & 2 deletions tests/QuiverCNBCTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public void Reader_ParsesCompactFormat()
Assert.AreEqual(symbol, result.Symbol);
Assert.AreEqual(new DateTime(2026, 5, 7), result.Time);
Assert.AreEqual(new DateTime(2026, 5, 8), result.EndTime);
Assert.AreEqual(new DateTime(2026, 5, 6), result.AdviceDate);
Assert.AreEqual(new DateTime(2026, 5, 7), result.AdviceDate);
Assert.AreEqual(OrderDirection.Buy, result.Direction);
Assert.AreEqual("Jim Cramer", result.Traders);
Assert.AreEqual("catalyst", result.Notes);
Expand Down Expand Up @@ -121,12 +121,25 @@ public void UniverseReader_ParsesCompactFormat()

Assert.AreEqual("AAPL", result.Symbol.Value);
Assert.AreEqual(new DateTime(2026, 5, 7), result.Time);
Assert.AreEqual(new DateTime(2026, 5, 6), result.AdviceDate);
Assert.AreEqual(new DateTime(2026, 5, 7), result.AdviceDate);
Assert.AreEqual(OrderDirection.Buy, result.Direction);
Assert.AreEqual("Jim Cramer", result.Traders);
Assert.AreEqual("catalyst", result.Notes);
}

[Test]
public void UniverseReader_EmptyAdviceDateFallsBackToDateMinusOne()
{
var factory = new QuiverCNBCsUniverse();
var line = "AAPL R735QTJ8XC9X,AAPL,,1,Steve Weiss,";

var result = (QuiverCNBCsUniverse)factory.Reader(null, line, new DateTime(2026, 5, 8), false);

Assert.AreEqual(new DateTime(2026, 5, 7), result.Time);
Assert.AreEqual(new DateTime(2026, 5, 7), result.AdviceDate);
Assert.AreEqual(OrderDirection.Sell, result.Direction);
}

private static SubscriptionDataConfig CreateConfig(Symbol symbol)
{
return new SubscriptionDataConfig(
Expand Down
Loading