wallet: show fee-only change-only self-transfers - #150
Open
kiwidream wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #147.
Fee-bearing self-transfers disappeared from default wallet history when every wallet-owned output was classified as change. This PR:
sendentry fromgettransaction,listtransactions, and defaultlistsinceblockoutput, withamount: 0, the negative fee, and no synthetic address, label, or vout;include_change=true;Testing
Commands/checks:
cmake --build build --target test_bitcoin-qt qbitd qbit-cli -j8ctest --test-dir build -R '^test_qbit-qt$' --output-on-failurebuild/test/functional/test_runner.py wallet_listsinceblock.py --jobs=1cmake --build build --target rpcdocs -j8ci/lint_imagefileTarget Branch
mainor a maintainer-requested release branch such as0.1.x.This PR targets the requested
1.x.xmaintenance branch.Risk / Review Notes
Notes: Wallet history presentation and RPC serialization change. Transaction construction, signing, coin selection, UTXO accounting, and balance calculation are unchanged.
Docs / Process Impact
Choose exactly one:
RPC help now documents the fee-only entry and the optional output-level fields.
libbitcoinpqc Subtree Checklist (if
src/libbitcoinpqcchanged)Not applicable;
src/libbitcoinpqcis unchanged.Qbit-Org/qbit-libbitcoinpqc.contrib/devtools/update-libbitcoinpqc-subtree.sh.test/lint/libbitcoinpqc-subtree-check.shpasses locally.contrib/devtools/update-libbitcoinpqc-subtree.shis intentional and matchesdoc/subtrees/libbitcoinpqc.md.Note
Cursor Bugbot is generating a summary for commit 8155f2b. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.