Backend chat observability: standardized request summary logging#148
Closed
akgohain wants to merge 1 commit into
Closed
Backend chat observability: standardized request summary logging#148akgohain wants to merge 1 commit into
akgohain wants to merge 1 commit into
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
request_id,endpoint,latency_ms,status, anderror_typefor quick diagnosis of stalls and failures.Description
_log_chat_request_summaryinserver_api/main.pythat emits single-line structured summary logs withrequest_id,endpoint,latency_ms,status, anderror_type./chat/query,/chat/clear,/chat/status,/chat/helper/query,/chat/helper/clear) to generate arequest_id, compute latency usingtime.perf_counter(), and call the summary helper on both success and error paths without including request payloads.tests/test_chat_logging_fields.pyto assert presence of the standardized fields in the summary log lines and to ensure sensitive text (e.g., thequerypayload) is not leaked.Testing
uv run pytest -q tests/test_chat_logging_fields.pywhich failed in this environment due to editable package metadata resolution forpytorch_connectomics(environment-specific issue).PYTHONPATH=. pytest -q tests/test_chat_logging_fields.pywhich passed (3 passed).Codex Task