Backend chat observability: add standardized request summary logs#147
Closed
akgohain wants to merge 1 commit into
Closed
Backend chat observability: add standardized request summary logs#147akgohain wants to merge 1 commit into
akgohain wants to merge 1 commit into
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
request_id,endpoint,latency_ms,status, anderror_typewhile preserving existing verbose behavior.Description
server_api/main.pyand emit a single-line JSON summary for/chat/queryand/chat/helper/queryin afinallyblock.request_idfrom the incomingx-request-idheader or a newuuid4, captureendpointfromreq.url.path, computelatency_msviatime.perf_counter(), and recordstatus(ok/error) anderror_typewhen exceptions occur.query,fieldContext, message content, or other payloads) to avoid sensitive data leakage.tests/test_chat_logging_fields.pythat capture logger output withself.assertLogsand assert presence and types of the standardized fields for a success path and an error path.Testing
PYTHONPATH=. pytest -q tests/test_chat_logging_fields.pywhich passed (2 passed) verifying both success and error logging behaviors.uv run pytest -q tests/test_chat_logging_fields.pybut it failed in this environment due to packaging/metadata for the editablepytorch_connectomicsdependency (unrelated to the changes); the focusedPYTHONPATHinvocation was used to validate the new tests.Codex Task