fix(lsp): v0.25.4 severity parity and deterministic UX - #184
Merged
Conversation
…rity (LSP-FIX-014) Eradicates the deterministic divergence between CLI DQS (25/100, batch mode, all findings) and LSP DQS (71/100, incremental mode, topological findings only). Root cause: the LSP operated in incremental mode and only observed Z1xx/Z4xx topological findings from the VSM. Content findings (Z5xx) on closed files were never analysed, so the in-editor score was non-deterministically lower than the authoritative CLI batch score. Displaying a misleading score violated the Determinism architectural invariant. Changes: - server.py: remove zenzic/dqsUpdate notification emission. The authoritative DQS is produced exclusively by `zenzic check all --strict` in CI/CD. - incremental.py: filter INFO-level findings at the transport boundary in _findings_to_diagnostics. INFO findings (e.g. Z106) carry no actionable remediation and pollute the VS Code PROBLEMS panel. - tests/test_lsp.py: update two DQS tests to assert the Determinism invariant (zenzic/dqsUpdate is NOT emitted) and rename accordingly. Architectural invariants preserved: - Determinism: a score that cannot be proven to match the CLI is not shown. - Thin Client: simplified, honest Status Bar (Zenzic: Running only). Fixes: LSP-FIX-014-DETERMINISM-AND-UX Signed-off-by: PythonWoods <gianluca.catalano@gmail.com>
Signed-off-by: PythonWoods <gianluca.catalano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Deploy patch release
0.25.4to enforce strict Severity Parity between the CLI and the LSP server, and to eradicate deterministic divergence by deprecating misleading partial metrics in the IDE.Architectural Changes
LSP-FIX-013): Added a strict filter in the LSP incremental engine (_findings_to_diagnostics) to drop findings withSeverity.INFO(e.g., Z106). This aligns the LSP's default visibility threshold with the CLI, eliminating non-actionable noise in the VS Code PROBLEMS panel.LSP-FIX-014): Removed the partial, in-memory DQS calculation and thezenzic/dqsUpdateJSON-RPC notification from the LSP server. Because the LSP operates incrementally (only analyzing opened/modified files for AST rules), its DQS calculation mathematically diverged from the CLI's global batch analysis. Removing this misleading metric restores the Single Source of Truth invariant.Verification
uv run zenzic check all --strictpassed (DQS 98/100).pytestsuite passed (1484/1484).INFOfindings no longer pollute the LSP output.