Add DatasetResource.mark_failed for async fetch failures#89
Merged
Conversation
In the async submit/collect flow a source can now mark an individual DatasetResource as failed-to-fetch (dataset_resource.mark_failed(error)) and yield it from collect(). ingestify records it as a FAILED task without storing anything (no revision, so it is retried next run) instead of the failure being silently dropped. The failure is now visible in the ingestion job summary. The FAILED task mirrors the operation that would have run: UPDATE when the resource already had a dataset (a failed refetch), CREATE otherwise. A failed fetch is never represented as a bad/failed dataset — the existing dataset is left untouched and recovers on the next successful run, so the existing fetch/retry behaviour keeps working. Claude-Session: https://claude.ai/code/session_01B5EfLJqoafjW1FhvkxGSmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the async submit/collect flow a source can now mark an individual DatasetResource as failed-to-fetch (dataset_resource.mark_failed(error)) and yield it from collect(). ingestify records it as a FAILED task without storing anything (no revision, so it is retried next run) instead of the failure being silently dropped. The failure is now visible in the ingestion job summary.