Skip to content

perf: make fill_missing_coords copy lazily (skip the no-op deep copy) #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FBumann merged 1 commit into from
Jul 16, 2026
Merged

perf: make fill_missing_coords copy lazily (skip the no-op deep copy) #844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions linopy/alignment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,16 +354,17 @@ def fill_missing_coords(
Whether to fill in integer coordinates for helper dimensions, by default False.

"""
ds = ds.copy()
if not isinstance(ds, Dataset | DataArray):
raise TypeError(f"Expected xarray.DataArray or xarray.Dataset, got {type(ds)}.")

skip_dims = [] if fill_helper_dims else HELPER_DIMS
missing = [d for d in ds.dims if d not in ds.coords and d not in skip_dims]
if not missing:
return ds

# Fill in missing integer coordinates
for dim in ds.dims:
if dim not in ds.coords and dim not in skip_dims:
ds.coords[dim] = arange(ds.sizes[dim])
ds = ds.copy()
for dim in missing:
ds.coords[dim] = arange(ds.sizes[dim])

return ds

Expand Down