internal: preliminary fixes for PyPy 3.12 - #6374
Merged
Merged
Conversation
| ) -> *mut PyObject; | ||
|
|
||
| #[cfg(Py_3_12)] | ||
| #[cfg_attr(PyPy, link_name = "PyPyObject_GetTypeData")] |
Member
There was a problem hiding this comment.
Is this intentional? Does it not have the PyPy prefix?
Contributor
There was a problem hiding this comment.
Yes, this is intentional. PyPy3.12 is moving to a model where the limited API interfaces will match 1:1 CPython, in preparation for being able to use abi3 c-extension modules without recompilation. There is more to do, we have not released 3.12 yet.
Member
Author
There was a problem hiding this comment.
Yes, I found some mention of this at pypy/pypy#3397 (comment)
bschoenmaeckers
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6345
Fixes #6244
This lands some preliminary fixes to get the PyPy 3.12 test suite moving further along based on local testing.