internal: no std mutex - #6058
Merged
Merged
Conversation
Person-93
force-pushed
the
no_std_mutex
branch
2 times, most recently
from
May 18, 2026 23:54
b7b3dae to
7d53f79
Compare
Person-93
marked this pull request as draft
May 18, 2026 23:55
Person-93
force-pushed
the
no_std_mutex
branch
2 times, most recently
from
May 19, 2026 00:15
9bb808d to
465c958
Compare
Merging this PR will improve performance by 10.54%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_empty_class_init |
31.7 µs | 28.7 µs | +10.54% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Person-93:no_std_mutex (f057746) with main (58d00a1)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Person-93
marked this pull request as ready for review
May 19, 2026 01:22
Person-93
force-pushed
the
no_std_mutex
branch
2 times, most recently
from
May 19, 2026 01:54
e393415 to
2988f07
Compare
Person-93
force-pushed
the
no_std_mutex
branch
3 times, most recently
from
May 26, 2026 19:23
acf2af4 to
9dec55b
Compare
davidhewitt
reviewed
Jun 4, 2026
Person-93
force-pushed
the
no_std_mutex
branch
5 times, most recently
from
June 15, 2026 21:16
d5c4af8 to
2e08460
Compare
Person-93
marked this pull request as draft
June 22, 2026 18:59
Contributor
Author
|
I've moved the |
Person-93
marked this pull request as ready for review
July 27, 2026 01:45
Person-93
force-pushed
the
no_std_mutex
branch
2 times, most recently
from
July 30, 2026 01:31
7307675 to
ecf8705
Compare
Person-93
force-pushed
the
no_std_mutex
branch
from
August 27, 2026 22:14
9e91eda to
7450502
Compare
davidhewitt
approved these changes
Aug 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to prepare for
no_stdsupport.I've added
non_poison::MutexandOnceto theplatformmod.There was once place that relied on poisoning for correctness:
err_state.rs, but that didn't really need a mutex because it was guarding aCopytype, I've replaced it with aCell.