Fix material_design palette on MicroPython and CircuitPython - #5
Merged
Conversation
Replace zip(..., strict=True) with an explicit length check. MicroPython does not support the strict keyword on zip, which broke get_palette when name is material_design (e.g. calc_graphics, palettes_demo).
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
get_palette(name="material_design")on MicroPython and CircuitPython.MicroPython does not support
strict=Trueonzip().MDPalette._define_named_colorsusedzip(FAMILIES, LENGTHS, strict=True), which raisedTypeError: function doesn't take keyword argumentsand broke pydisplay examples such ascalc_graphicsandpalettes_demo(material step).Change
Replace
zip(..., strict=True)with an explicit length check plus plainzip(FAMILIES, LENGTHS).Testing
MicroPython smoke:
micropython -c "import sys; sys.path.insert(0,'src'); from palettes import get_palette; get_palette('material_design')"Paired with pydisplay#78.