Skip to content

Change Y034 rule such that it does not emit errors in protocols#541

Open
jonathandung wants to merge 6 commits intoPyCQA:mainfrom
jonathandung:main
Open

Change Y034 rule such that it does not emit errors in protocols#541
jonathandung wants to merge 6 commits intoPyCQA:mainfrom
jonathandung:main

Conversation

@jonathandung
Copy link
Copy Markdown

Closes #539.

Y034 now is not supposed to apply in a protocol class, so add a test for this behaviour.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Member

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you also change the wording of Y034 in ERRORCODES.md? One more note below.

jonathandung and others added 2 commits April 8, 2026 19:41
Co-authored-by: Sebastian Rittau <sebastian.rittau@zfutura.de>
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

This change has no effect on typeshed. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y034 emits spurious warnings for almost always intended usage in protocols

3 participants