Fix spurious nosec warnings on multiline statements#1359
Open
worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
Open
Fix spurious nosec warnings on multiline statements#1359worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
Conversation
When a `# nosec` comment appears on one line of a multiline statement (e.g., a dict literal spanning multiple lines), bandit was checking the entire statement's line range for nosec comments. This caused "nosec encountered but no failed test" warnings on every other line of the same statement. The fix checks only the specific line being tested for a nosec comment, not the full linerange of the multiline node. Fixes PyCQA#1352
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1352.
When a
# nosec B105comment appears on one line of a multiline statement (e.g., a dict literal spanning lines 1-17), bandit checks the entire statement's line range for nosec comments viautils.get_nosec(). This means every line of the multiline statement is treated as having a nosec comment, and for each line where the test doesn't fire, bandit warns:The fix changes the "no result" warning path to check only
nosec_lines.get(temp_context["lineno"])(the specific line being checked) rather than searching the entire linerange. This way, the warning is only emitted for the line that actually has the# noseccomment, not for every line in the multiline statement.