Fix "physicalLocation" calculation for SARIF#1312
Open
jerrdasur wants to merge 3 commits intoPyCQA:mainfrom
Open
Fix "physicalLocation" calculation for SARIF#1312jerrdasur wants to merge 3 commits intoPyCQA:mainfrom
jerrdasur wants to merge 3 commits intoPyCQA:mainfrom
Conversation
Required line awlays goes second in code snippet. We can use this knowledge for simple and correct snippet generation in bandit.formatters.sarif.add_region_and_context_region. Resolves: PyCQA#1311
jerrdasur
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
ericwb
reviewed
Oct 27, 2025
Member
ericwb
left a comment
ericwb
left a comment
There was a problem hiding this comment.
Could you provide the file that caused the error? Or better yet, expand the tests to test this scenario.
Author
|
According to "Reproduction Steps" in mentioned issue you will need: https://github.com/harishsg993010/damn-vulnerable-MCP-server/blob/main/tests/conftest.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required line always goes second in code snippet. We can use this knowledge for simple and correct snippet generation in
bandit.formatters.sarif.add_region_and_context_region.Resolves: #1311