Serialize the AppStorage test suite#70
Closed
colemancda wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppStorage tests each reassign the process-global
AppStorageStore.backend, so under Swift Testing's parallel execution one test could swap the backend mid-run and another would see nil reads (e.g. in "Each supported type round-trips under its own key").Mark the suite
.serializedso its four tests run one at a time; no other suite touches the backend, so the rest of the run stays fully parallel.Verified with 5 consecutive filtered runs and 3 consecutive full
swift testruns, all passing.