Fix convert_uu* AOT compile (bridge BB emission) — #4567#18772
Merged
Conversation
Emit decode bridge basic blocks on the bridge function instead of the active user-script insert function, and save/restore the LLVM insert block around StringConvertUu::implement() so nested helper lowering no longer leaves the builder in an invalid state. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
User-script AOT nested ConvertUuJitHelper segfaults at runtime; defer to restored LLVM bodies (base64 pattern) while JIT/embed keep PHP bridge. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Maintainer review 2026-07-14: hold merge — PR correctly targets AOT compile (#4567 bridge BB emission) and documents the remaining AOT runtime failure ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_uuencode()/convert_uudecode()(Current basic block has no parent functionon master).ConvertUuJitHelperreturned corrupt encode results / segfaulted; defer to restored LLVM bodies onUserScriptAotDeferNestedJit(same pattern as base64 Stdlib/AOT: standalone binary run segfault (exit 139) after compile — Docker harness JIT-linked builtins #16734).ConvertUuJitHelperPHP bridge (php-in-php: delete StringConvertUuJit — route convert_uuencode/uudecode through ConvertUuJitHelper PHP (#6307 follow-up) #13227).php-src reference:
ext/standard/uuencode.c— PHP bridge inext/standard/ConvertUuJitHelper.php, standalone AOT LLVM inext/standard/JitConvertUuBodies.php.Closes #4567
Verification