php-in-php: split StreamReadBridgeLlvm from StreamReadRuntime (#18672)#18677
Merged
Conversation
Move LLVM ABI bridges and deferred inventory stubs into StreamReadBridgeLlvm so StreamReadRuntime stays a thin StreamReadJitHelper orchestrator (198 LOC, under the 360-line shrink-test ceiling). Semantics unchanged — PHP SSOT remains ext/standard/StreamReadJitHelper.php. Closes #18672 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamReadRuntime.phpinto newStreamReadBridgeLlvm.php(HashTableRead/WriteLlvm split pattern from php-in-php: JIT HashTableHelper — route hashtable LLVM through VmHashTable PHP not ~2.6k-line monolith (#1492) #10031).StreamReadRuntime.phpis now a thinStreamReadJitHelperorchestrator (198 LOC, was ~476).StreamReadBridgeLlvm.phpbeforeStreamReadRuntime.php.Semantics unchanged — SSOT remains
ext/standard/StreamReadJitHelper.php(#9393, #12937).C runtime shrink
No hand-written C in
lib/AOT/runtime/(already empty per #17148). This run shrinks the JIT runtime monolith by moving ~278 lines of inline LLVM emission out ofStreamReadRuntime.php.StreamReadRuntime.phpStreamReadBridgeLlvm.phpVerification
Closes #18672
Made with Cursor