Skip to content

php-in-php: re-delete ParseStrUserScriptDelimitedJit — MultipartRuntime PHP makes #18548 obsolete (#18643)#18645

Merged
PurHur merged 1 commit into
masterfrom
agent/runtime-php-parse-str-delimited-delete
Jul 13, 2026
Merged

php-in-php: re-delete ParseStrUserScriptDelimitedJit — MultipartRuntime PHP makes #18548 obsolete (#18643)#18645
PurHur merged 1 commit into
masterfrom
agent/runtime-php-parse-str-delimited-delete

Conversation

@PurHur

@PurHur PurHur commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #18643

C runtime shrink

Removed Lines
lib/JIT/Builtin/ParseStrUserScriptDelimitedJit.php −1052

Verification

php vendor/bin/phpunit test/unit/ParseStrRuntimeShrinkTest.php
# OK (13 tests, 63 assertions)

php vendor/bin/phpunit test/unit/SuperglobalRefreshRuntimeShrinkTest.php
# OK (4 tests)

php vendor/bin/phpunit test/unit/JIT/SuperglobalsBracketRuntimeStandaloneTest.php
# OK (4 tests)

php script/check-selfhost-spine-coverage-sync.php
# OK (spine covers all 4774 inventory files)

php script/bootstrap-inventory.php --check
# OK 4774/4774

make bootstrap-selfhost-vm-driver-execute-probe
# bootstrap-selfhost-vm-driver-execute-probe: OK

Note: ./script/check-aot-build-smoke.sh fails on master too (pre-existing __value__writeHashtable module-verify regression); not introduced by this diff.

Made with Cursor

…untime PHP (#18643)

#18548 restored ~1052 LOC hand-LLVM delimited parse subhelpers for
StringMultipartStandaloneLlvm; #18615 routes multipart through
MultipartNativeJitHelper + ParseStrNativeJitHelper PHP instead.

Verification:
- php vendor/bin/phpunit test/unit/ParseStrRuntimeShrinkTest.php → OK (13)
- php vendor/bin/phpunit test/unit/SuperglobalRefreshRuntimeShrinkTest.php → OK
- php vendor/bin/phpunit test/unit/JIT/SuperglobalsBracketRuntimeStandaloneTest.php → OK
- php script/check-selfhost-spine-coverage-sync.php → OK
- make bootstrap-selfhost-vm-driver-execute-probe → OK

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur PurHur merged commit 73b3cc2 into master Jul 13, 2026
@PurHur PurHur deleted the agent/runtime-php-parse-str-delimited-delete branch July 13, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: re-delete ParseStrUserScriptDelimitedJit — MultipartRuntime PHP makes #18548 LLVM restore obsolete (#1492)

1 participant