php-in-php: re-delete ParseStrUserScriptDelimitedJit — MultipartRuntime PHP makes #18548 obsolete (#18643)#18645
Merged
Conversation
…untime PHP (#18643) #18548 restored ~1052 LOC hand-LLVM delimited parse subhelpers for StringMultipartStandaloneLlvm; #18615 routes multipart through MultipartNativeJitHelper + ParseStrNativeJitHelper PHP instead. Verification: - php vendor/bin/phpunit test/unit/ParseStrRuntimeShrinkTest.php → OK (13) - php vendor/bin/phpunit test/unit/SuperglobalRefreshRuntimeShrinkTest.php → OK - php vendor/bin/phpunit test/unit/JIT/SuperglobalsBracketRuntimeStandaloneTest.php → OK - php script/check-selfhost-spine-coverage-sync.php → OK - make bootstrap-selfhost-vm-driver-execute-probe → OK Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/Builtin/ParseStrUserScriptDelimitedJit.php(~1052 LOC hand-LLVM) restored temporarily in Fix AOT link: restore parse_str delimited LLVM for multipart refresh (#1492) #18548 forStringMultipartStandaloneLlvmlink symbols.MultipartNativeJitHelper+ParseStrNativeJitHelperPHP;ParseStrRuntime::ensureUserScriptLinkedno longer callsensureSubhelpers.SuperglobalsBracketRuntimeStandaloneTestwithParseStrRuntimeShrinkTest— expect__compiler_parse_strbridges, not__phpc_parse_str_*LLVM.Closes #18643
C runtime shrink
lib/JIT/Builtin/ParseStrUserScriptDelimitedJit.phpVerification
Note:
./script/check-aot-build-smoke.shfails on master too (pre-existing__value__writeHashtablemodule-verify regression); not introduced by this diff.Made with Cursor