php-in-php: delete GcCollectCyclesStandaloneLlvm — standalone AOT GC via PHP helpers (#18630)#18640
Merged
Merged
Conversation
…via PHP helpers (#18630) Route standalone AOT gc_register/collect through GcCollectCyclesRegistryJitHelper and GcCollectCyclesJitHelper::collectCyclesStandalone; remove ~516-line LLVM monolith and ~500 lines of dead registry LLVM in GcCollectCyclesRuntime. Closes #18630. Co-authored-by: Cursor <cursoragent@cursor.com>
…18630) Split standalone AOT collect from embed GcCollectCyclesJitHelper so nested JIT during phpc build avoids Superglobals/CycleCollector. Shared scan lives in GcCollectCyclesNativeScanJitHelper; stats/collect bridge in StandaloneJitHelper. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
PurHur
added a commit
that referenced
this pull request
Jul 13, 2026
#18640 nested-JIT of GcCollectCyclesNativeScanJitHelper broke all standalone AOT compiles (LLVM module verify: writeHashtable type mismatch). Restore GcCollectCyclesStandaloneLlvm for standalone collect/registry; keep PHP registry on embed. Hash context incremental AOT + HelloWorld compile green again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*StandaloneLlvmGC file (GcCollectCyclesStandaloneLlvm.php, ~516 lines) and ~500 lines of dead LLVM registry/collect code inGcCollectCyclesRuntime.php.phpc_gc_register/phpc_gc_collect_cycles_implthroughGcCollectCyclesRegistryJitHelper+GcCollectCyclesStandaloneJitHelper(shared native scan inGcCollectCyclesNativeScanJitHelper).GcCollectCyclesJitHelper::collectCyclesEmbednow delegates native scan to the shared helper.Closes #18630.
C/LLVM shrink
lib/JIT/Builtin/GcCollectCyclesStandaloneLlvm.php(516 lines)phpc_gc_objects[], marked/inbound arrays) and LLVM monolith branches inGcCollectCyclesRuntime.phpVerification
Note:
./script/check-aot-build-smoke.shtier-1 hello-world build is already red on master (LLVM verify__value__writeHashtablemismatch) — not introduced by this PR.Made with Cursor