Skip to content

fix: cancelOrder now returns transaction hash like cancelOrders #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sertug17 wants to merge 1 commit into from
Closed

fix: cancelOrder now returns transaction hash like cancelOrders #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sdk/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,14 +478,17 @@ export class BaseOpenSeaSDK {
return this._cancellationManager.cancelOrders(options)
}

/** Cancel an order onchain, preventing it from ever being fulfilled. */
/**
* Cancel an order onchain, preventing it from ever being fulfilled.
* @returns Transaction hash of the cancellation.
*/
public async cancelOrder(options: {
order?: OrderV2
orderHash?: string
accountAddress: string
protocolAddress?: string
domain?: string
}) {
}): Promise<string> {
return this._cancellationManager.cancelOrder(options)
}

Expand Down
3 changes: 2 additions & 1 deletion src/sdk/cancellation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class CancellationManager {
accountAddress: string
protocolAddress?: string
domain?: string
}) {
}): Promise<string> {
// Validate input
if (!order && !orderHash) {
throw new Error(
Expand Down Expand Up @@ -106,6 +106,7 @@ export class CancellationManager {
EventType.CancelOrder,
"Cancelling order",
)
return transactionHash
}

/**
Expand Down