Upstream Commits#1
Open
LoboMetalurgico wants to merge 253 commits into
Open
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.0.14 to 8.0.16. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.0.16/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.0.16 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
A backslash followed by a space was baking that space into the escape token, so the newline rule saw only one trailing space and emitted a soft break instead of the mandated hard line break. Per CommonMark 0.31.2 section 6.1, a backslash before a space is a literal backslash and the space is not consumed. Leaving the space in the text stream lets section 6.7 two-space hard-break detection fire. Input `a\ \nb` (backslash + two trailing spaces) now renders `<p>a\<br>\nb</p>` instead of `<p>a\ \nb</p>`.
…ark 6.3) (#1188) A backslash followed by a space inside a link destination is a literal backslash (a space is not ASCII punctuation, so it is not escaped), and the space ends the destination. markdown-it instead broke at the backslash, dropping it from the destination and failing to parse the link. Repro: md.render('[a](/url\\ )') Expected (matches the CommonMark 0.31.2 reference renderer): <p><a href="/url%5C">a</a></p> Actual on master: <p>[a](/url\ )</p> In lib/helpers/parse_link_destination.mjs the unenclosed-destination loop, on seeing `\` followed by a space, called `break`, which excludes the backslash from the destination and leaves `\ )` unconsumed so the link fails. Advance past the backslash instead (`pos++; continue`) so it is kept literal and the following space triggers the normal terminator. The existing commonmark/commonmark-spec#493 case `[a](a\ b)` is unaffected: content after the space still prevents the link from parsing, matching the reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.