Skip to content

ph.points & ashrae.g36: extend ModulatingSensor & ModulatingCmd to actuators & valves #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rick-jennings wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −22
Open

ph.points & ashrae.g36: extend ModulatingSensor & ModulatingCmd to actuators & valves #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/xeto/ashrae.g36/vavs.xeto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ G36FanPoweredTerminalUnit : G36Vav {
DischargeFanRunSensor
DischargeFanRunCmd
DischargeDamperCmd
HotWaterValveCmd
HotWaterValveModulatingCmd
DischargeAirFlowSensor
DischargeAirTempSensor
}
Expand Down Expand Up @@ -65,7 +65,7 @@ G36ReheatVav : G36Vav {
hotWaterHeating
singleDuct
points: {
HotWaterValveCmd
HotWaterValveModulatingCmd
DischargeDamperCmd
DischargeAirFlowSensor
DischargeAirTempSensor
Expand Down
2 changes: 1 addition & 1 deletion src/xeto/doc.xeto/Sugar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ sugar spec:
+StandardVav {
hotWaterHeating
points: {
HotWaterValveCmd
HotWaterValveModulatingCmd
}
}

Expand Down
16 changes: 16 additions & 0 deletions src/xeto/ph.points/actuator.xeto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//
// Copyright (c) 2026, Project-Haystack
// Licensed under the Academic Free License version 3.0
//
// History:
// 26 Aug 2026 Rick Jennings Creation
//

// Sensor for modulating actuator position. Position is measured as a
// percentage where 0% is closed and 100% is fully open.
ActuatorModulatingSensor : ModulatingSensor { actuator }

// Command for modulating actuator position. Position is measured as a
// percentage where 0% is closed and 100% is fully open.
ActuatorModulatingCmd : ModulatingCmd { actuator }

37 changes: 18 additions & 19 deletions src/xeto/ph.points/valve.xeto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,34 @@
// 3 Nov 2022 Brian Frank Creation
//

// Point associated with a valve; 0% is fully closed and 100% is fully open.
ValvePoint : NumberPoint <abstract> {
valve
unit: Unit <invariant> "%"
}
// Sensor for modulating valve position. Position is measured as a
// percentage where 0% is closed and 100% is fully open.
ValveModulatingSensor : ActuatorModulatingSensor { valve }

// Valve position sensor; 0% is fully closed and 100% is fully open.
ValveSensor : ValvePoint & SensorPoint <abstract>

// Valve position command; 0% is fully closed and 100% is fully open.
ValveCmd : ValvePoint & CmdPoint <abstract>
// Command for modulating valve position. Position is measured as a
// percentage where 0% is closed and 100% is fully open.
ValveModulatingCmd : ActuatorModulatingCmd { valve }

//////////////////////////////////////////////////////////////////////////
// Chilled Water
//////////////////////////////////////////////////////////////////////////

// Valve sensor for chilled water
ChilledWaterValveSensor : ValveSensor { chilled, water }
// Sensor for chilled water modulating valve position. Position is
// measured as a percentage where 0% is closed and 100% is fully open.
ChilledWaterValveModulatingSensor : ValveModulatingSensor { chilled, water }

// Valve commad for hot water
ChilledWaterValveCmd : ValveCmd { chilled, water }
// Command for chilled water modulating valve position. Position is
// measured as a percentage where 0% is closed and 100% is fully open.
ChilledWaterValveModulatingCmd : ValveModulatingCmd { chilled, water }

//////////////////////////////////////////////////////////////////////////
// Hot Water
//////////////////////////////////////////////////////////////////////////

// Valve sensor for hot water
HotWaterValveSensor : ValveSensor { hot, water }

// Valve commad for hot water
HotWaterValveCmd : ValveCmd { hot, water }
// Sensor for hot water modulating valve position. Position is
// measured as a percentage where 0% is closed and 100% is fully open.
HotWaterValveModulatingSensor : ValveModulatingSensor { hot, water }

// Command for hot water modulating valve position. Position is
// measured as a percentage where 0% is closed and 100% is fully open.
HotWaterValveModulatingCmd : ValveModulatingCmd { hot, water }