docs(scheduler): document per-pod scoring weights - #759
Conversation
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @blackdragoon26! It looks like this is your first PR to Project-HAMi/website 🎉 |
📝 WalkthroughWalkthroughThe scheduling guide documents per-Pod device-scoring weights for slot, core, and memory utilization. It also updates GPU binpack and spread formulas and examples to include virtual-device slot utilization. ChangesGPU scoring documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM |
FouoF
left a comment
There was a problem hiding this comment.
The doc seem placing incorrect. This is a user-face change so it should update or draft a user guide instead of developer doc. Also better add a Chinese version.
Thanks for the review. |
|
@FouoF , sorry to ping you again |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documents the per-Pod device-scoring weights introduced by Project-HAMi/HAMi#2469.
This update:
hami.io/device-scoring-weightsannotationThis PR depends on Project-HAMi/HAMi#2469. The documented contract should be finalised together with that implementation.
Which issue(s) this PR fixes:
Fixes #758
I have not done the Chinese translation in this PR yet. This documents an unreleased feature in the English source-of-truth page, once I can get an initial review and green flag, I would update the the translation version as well in the PR
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)AI Disclosure:
Codex was used to cross-check the implementation semantics and calculations, and to help draft the documentation. I reviewed and verified the final content and test results.
Summary by CodeRabbit