Skip to content

docs: fix global nvidia driver link in helm guide - #745

Merged
rootsongjc merged 1 commit into
Project-HAMi:masterfrom
Sundram777:fix/docs-improvement
Aug 12, 2026
Merged

docs: fix global nvidia driver link in helm guide#745
rootsongjc merged 1 commit into
Project-HAMi:masterfrom
Sundram777:fix/docs-improvement

Conversation

@Sundram777

@Sundram777 Sundram777 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Updates the NVIDIA Driver link in docs/get-started/deploy-with-helm.md from the .cn localized domain to the global .com domain for consistency in English documentation.

Which issue(s) this PR fixes:
N/A

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • [N/A] Chinese translation updated if English docs changed (URL fix for English docs link)
  • Commits are signed off (git commit -s)

Summary by CodeRabbit

  • Documentation
    • Updated the NVIDIA Driver prerequisite link to the global NVIDIA drivers site.
    • The required driver version remains v440 or later.

Signed-off-by: Sundram Singh <sundramsingh527@gmail.com>
@hami-robot hami-robot Bot added kind/documentation Improvements or additions to documentation dco-signoff: yes labels Aug 8, 2026
@hami-robot
hami-robot Bot requested review from mesutoezdil and windsonsea August 8, 2026 19:01
@netlify

netlify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 66d84f9
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a777d0f15f8970008c26c1b
😎 Deploy Preview https://deploy-preview-745--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot

hami-robot Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Welcome @Sundram777! It looks like this is your first PR to Project-HAMi/website 🎉

@hami-robot hami-robot Bot added the size/XS label Aug 8, 2026
@github-actions github-actions Bot added area/docs and removed size/XS labels Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 82472eff-92c5-48e4-871e-76b36fd3f1e4

📥 Commits

Reviewing files that changed from the base of the PR and between cdf5f73 and 66d84f9.

📒 Files selected for processing (1)
  • docs/get-started/deploy-with-helm.md

📝 Walkthrough

Walkthrough

The Helm deployment guide now links to the global NVIDIA drivers site. The required NVIDIA Driver version remains v440+.

Changes

Helm deployment documentation

Layer / File(s) Summary
Update NVIDIA Driver prerequisite link
docs/get-started/deploy-with-helm.md
The prerequisite link now uses www.nvidia.com/drivers/unix/ instead of www.nvidia.cn/drivers/unix/. The v440+ requirement is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: mesutoezdil, rootsongjc

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the NVIDIA driver link update in the Helm guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/XS label Aug 8, 2026

@rootsongjc rootsongjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot

hami-robot Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rootsongjc, Sundram777
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootsongjc
rootsongjc merged commit 8c77efb into Project-HAMi:master Aug 12, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants