📝 修改文档 -> 海光DCU全系列已支持HAMi#436
Conversation
Signed-off-by: kinglong <daijl@sugon.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kinglong08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
windsonsea
left a comment
windsonsea
left a comment
There was a problem hiding this comment.
oh, could you only modify the 海光 related, and leave other unchanged?
yes ~ |
|
@kinglong08 there are some conflicts. |
Signed-off-by: kinglong <daijl@sugon.com>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe docs update Hygon/DCU support references from specific models to All/全部 across the roadmap, device-support pages, and FAQ tables in current, translated, and versioned copies. ChangesDevice support documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: kinglong <daijl@sugon.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@versioned_docs/version-v2.4.1/userguide/device-supported.md`:
- Line 7: The table header has a typo in the device support docs: “manufactor”
should be normalized to “Manufacturer”. Update the header in this table and make
the same spelling change in the other versioned copies of the same table so the
docs remain consistent across versions, using the table markup in the
device-supported documentation as the reference point.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 771703d1-87af-4d70-9fff-b292cda4c9fb
📒 Files selected for processing (24)
docs/contributor/roadmap.mddocs/faq/faq.mddocs/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/current/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/current/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v1.3.0/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.5.0/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.5.1/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.6.0/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.6.0/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.7.0/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.7.0/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.8.0/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/version-v2.8.0/userguide/device-supported.mdversioned_docs/version-v1.3.0/userguide/device-supported.mdversioned_docs/version-v2.4.1/userguide/device-supported.mdversioned_docs/version-v2.5.0/userguide/device-supported.mdversioned_docs/version-v2.5.1/userguide/device-supported.mdversioned_docs/version-v2.6.0/faq/faq.mdversioned_docs/version-v2.6.0/userguide/device-supported.mdversioned_docs/version-v2.7.0/faq/faq.mdversioned_docs/version-v2.7.0/userguide/device-supported.mdversioned_docs/version-v2.8.0/faq/faq.mdversioned_docs/version-v2.8.0/userguide/device-supported.md
Signed-off-by: kinglong <daijl@sugon.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md`:
- Around line 184-192: Revert the unrelated NVIDIA MIG comparison table changes
in the FAQ doc so this Hygon/DCU-only section stays focused on the intended
scope. Keep the existing HAMi vGPU content unchanged and remove the edits to the
MIG rows in the table within the FAQ markdown content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5c5d87ac-f1da-4ae0-8448-c04ccb7d1bdc
📒 Files selected for processing (2)
docs/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md
✅ Files skipped from review due to trivial changes (1)
- docs/faq/faq.md
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md`:
- Around line 184-192: Revert the unrelated NVIDIA MIG comparison table changes
in the FAQ doc so this Hygon/DCU-only section stays focused on the intended
scope. Keep the existing HAMi vGPU content unchanged and remove the edits to the
MIG rows in the table within the FAQ markdown content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5c5d87ac-f1da-4ae0-8448-c04ccb7d1bdc
📒 Files selected for processing (2)
docs/faq/faq.mdi18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md
✅ Files skipped from review due to trivial changes (1)
- docs/faq/faq.md
🛑 Comments failed to post (1)
i18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md (1)
184-192: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the unrelated MIG-table edit.
This hunk changes the NVIDIA MIG comparison table, which is outside the Hygon/DCU-only scope called out in the PR objectives. Please revert it unless this was meant to be a separate docs change.
Suggested revert
-| 硬件要求 | 任意 NVIDIA GPU，驱动 v440+ | Ampere 及更新架构（A100、H100、A30、H200） | +| 硬件要求 | 任意 NVIDIA GPU，驱动 v440+ | Ampere 及更新架构（A100、H100、A30） |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.| 属性 | HAMi vGPU | NVIDIA MIG | | -------------- | ----------------------------- | ------------------------------------------ | | 硬件要求 | 任意 NVIDIA GPU，驱动 v440+ | Ampere 及更新架构（A100、H100、A30） | | 隔离机制 | 用户态库拦截 | 硬件引擎分区 | | 显存限制 | 软限制（CUDA API 级别） | 硬限制（硬件强制） | | 算力限制 | 软限制（libvgpu.so 内部节流） | 硬限制（独立 SM 分区） | | 分区粒度 | 1 MiB 显存，1% 算力 | 固定 MIG 配置（如 1g.10gb） | | 动态重配置 | 支持，无需排空节点 | 需要重新配置 MIG 配置文件 | | 多租户噪声隔离 | 尽力而为 | 强隔离 |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@i18n/zh/docusaurus-plugin-content-docs/current/faq/faq.md` around lines 184 - 192, Revert the unrelated NVIDIA MIG comparison table changes in the FAQ doc so this Hygon/DCU-only section stays focused on the intended scope. Keep the existing HAMi vGPU content unchanged and remove the edits to the MIG rows in the table within the FAQ markdown content.
|
@kinglong08 CodeRabbit flagged a typo in the table header across multiple versioned docs:
Please fix before merge. |
3 participants
修改文档 -> 海光DCU全系列加速卡均已支持HAMi
Summary by CodeRabbit