add documentation for Biren#430
Conversation
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e27d656 to
c4871d1
Compare
Signed-off-by: james <open4pd@4paradigm.com>
c4871d1 to
d58339d
Compare
|
node label mismatch: the install step labels the node with but the DaemonSet nodeSelector: these do not match, so the DaemonSet will never schedule on a node labeled |
Signed-off-by: james <open4pd@4paradigm.com>
thanks you. All comments have been fixed. @mesutoezdil |
5030b0d to
f538817
Compare
Signed-off-by: james <open4pd@4paradigm.com>
f538817 to
0db201b
Compare
|
@windsonsea Could you please review this PR when you have a moment? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DSFans2014, windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@DSFans2014 there are some conflicts. |
the conflicts fixed. thanks |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdded Biren device documentation in English and Chinese, including sharing setup instructions, Pod request examples, usage notes, a device support table entry, and sidebar navigation. ChangesBiren device documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/userguide/biren-device/examples/default-use.md`:
- Line 5: The description in the Biren device example incorrectly says the Pod
runs a container image provided by Birentech, but the manifest uses a generic
ubuntu image. Update the prose in the example to remove the Birentech
attribution and keep it generic, matching the existing wording around the Pod,
container image, and resources.limits in the default-use example.
In
`@i18n/zh/docusaurus-plugin-content-docs/current/userguide/biren-device/enable-biren-sharing.md`:
- Around line 5-11: Update the localized introduction in the biren sharing guide
so it matches the English source: replace the mistranslated vendor/product name
with the correct one for the Biren device and remove the duplicated “SVI”
wording in the capability bullet. Keep the wording in the Introduction section
of enable-biren-sharing.md aligned with the corresponding English doc,
especially the device name and the “整卡和 SVI 切分” capability description.
In
`@i18n/zh/docusaurus-plugin-content-docs/current/userguide/biren-device/examples/default-use.md`:
- Line 5: Update the localized example text in the userguide Biren device docs
so the vendor name matches the English source and the rest of the doc set
branding. In the sentence describing the Kubernetes Pod example, replace the
current vendor name in the prose with 壁仞, and keep the rest of the example
wording aligned with the corresponding docs content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d09cf372-6398-4163-a24f-ea93472a07a8
📒 Files selected for processing (6)
docs/userguide/biren-device/enable-biren-sharing.mddocs/userguide/biren-device/examples/default-use.mddocs/userguide/device-supported.mdi18n/zh/docusaurus-plugin-content-docs/current/userguide/biren-device/enable-biren-sharing.mdi18n/zh/docusaurus-plugin-content-docs/current/userguide/biren-device/examples/default-use.mdsidebars.js
Signed-off-by: james <open4pd@4paradigm.com>
a899327 to
ec61f36
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary by CodeRabbit