docs: add 5-minute quick start path (#412)#425
Conversation
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Why not simply name this file “Quick Start”? That URL would be much more commonly used. |
done |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mesutoezdil, windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2137c21 to
5510be2
Compare
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
5510be2 to
ca8e69a
Compare
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new HAMi quick-start guide for Kubernetes, updates the Get Started sidebar, and extends the Helm deployment guide with repository refresh, readiness, cleanup, and next-step sections. ChangesQuick Start Guide and Sidebar
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/get-started/quick-start.md`:
- Line 6: The quick-start introduction overstates the setup as “a single Helm
command” even though the flow also requires adding and updating the Helm repo.
Update the intro in the quick-start guide to describe a minimal Helm-based
installation path that matches the actual steps, and align the summary wording
with the install flow used later in the document.
- Line 17: The admonition in quick-start should use the standard multi-line
block form instead of the one-line `:::note ... :::` shorthand. Update the note
around the node runtime prerequisite to a proper block admonition so it stays
consistent with the rest of the docs and is less likely to be misformatted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d6373cb9-eefb-4a98-917e-485000128b31
📒 Files selected for processing (2)
docs/get-started/quick-start.mdsidebars.js
|
The quick start button on the homepage is already linked to https://project-hami.io/docs/get-started/deploy-with-helm, and we can directly optimize that document, as it seems to have a lot of repetition with it. |
quick-start.md: - fix intro wording: "single Helm command" -> "minimal Helm-based install path" - convert inline :::note::: to multi-line block form deploy-with-helm.md: - add helm repo update after helm repo add - add kubectl wait step before verification - add Cleanup section - add Next steps section Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Per rootsongjc's review: the homepage quick start button already links to deploy-with-helm, so a separate quick-start page adds redundancy. Removed quick-start.md and its sidebar entry. The helm repo update, kubectl wait, cleanup, and next steps sections are already in deploy-with-helm.md from the previous commit. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
docs/get-started/quick-path.md: a minimal install-and-verify path targeting users with a running Kubernetes cluster and pre-configured GPU nodesenandzhlocalesScope
The quickstart covers exactly what the issue asks for:
helm repo add+helm install(two commands)kubectl labelcommandkubectl get pods -n kube-system | grep hami4096MiBTotal Memory, confirming isolationWhat is not included
Closes #412.
Summary by CodeRabbit