Skip to content

Week 3#3

Merged
magdalena-grubesa merged 21 commits into
mainfrom
week-3
May 27, 2026
Merged

Week 3#3
magdalena-grubesa merged 21 commits into
mainfrom
week-3

Conversation

@magdalena-grubesa

Copy link
Copy Markdown
Collaborator

No description provided.

@ZoiAsimakop ZoiAsimakop left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! :)
Can the package be installed? Yes, I cloned the week-3 branch, created a clean conda env on Python 3.12, ran pip install -e . and everything resolved cleanly with no errors or warnings.
Is the vignette set up correctly? Yes the docs/report.ipynb is really nicely organised. Clear narrative, well-structured, and the flowcharts are a lovely touch, I think they make the project structure and the user flow really easy to follow.
Did the unit tests run? Yes.
Did they pass? All 86.
Anything else? I also ran the Dash app (python -m study_smart.app) and the interface loads cleanly and the buttons work, which is great to see beyond just the unit tests.
Really nicely done overall! I might actually use this for my next exam prep!
Zoi

@erwardenaar erwardenaar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can the package be installed?

Yes, installs cleanly with pip install -e .

  • Is the vignette set up correctly?

Yes, runs without errors. But the Python version listed in the vignette (>=3.12) doesn't match pyproject.toml (>=3.11).

  • Did the unit tests run? Did they pass?

Yes, 37 tests, all passing. Coverage is strong (98% on schedule.py, 73% on google_calendar.py).

  • Anything else that comes to mind?

pytest and pytest-cov are not listed as dev dependencies in pyproject.toml

@magdalena-grubesa magdalena-grubesa merged commit dea4d7d into main May 27, 2026
2 checks passed
@magdalena-grubesa magdalena-grubesa deleted the week-3 branch May 27, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants