Week 3#3
Conversation
ZoiAsimakop
left a comment
There was a problem hiding this comment.
Hello! :)
Can the package be installed? Yes, I cloned the week-3 branch, created a clean conda env on Python 3.12, ran pip install -e . and everything resolved cleanly with no errors or warnings.
Is the vignette set up correctly? Yes the docs/report.ipynb is really nicely organised. Clear narrative, well-structured, and the flowcharts are a lovely touch, I think they make the project structure and the user flow really easy to follow.
Did the unit tests run? Yes.
Did they pass? All 86.
Anything else? I also ran the Dash app (python -m study_smart.app) and the interface loads cleanly and the buttons work, which is great to see beyond just the unit tests.
Really nicely done overall! I might actually use this for my next exam prep!
Zoi
erwardenaar
left a comment
There was a problem hiding this comment.
- Can the package be installed?
Yes, installs cleanly with pip install -e .
- Is the vignette set up correctly?
Yes, runs without errors. But the Python version listed in the vignette (>=3.12) doesn't match pyproject.toml (>=3.11).
- Did the unit tests run? Did they pass?
Yes, 37 tests, all passing. Coverage is strong (98% on schedule.py, 73% on google_calendar.py).
- Anything else that comes to mind?
pytest and pytest-cov are not listed as dev dependencies in pyproject.toml
No description provided.