fix(v7): resolve packaging, tsc path portability, and golden newline issues#219
Conversation
…ependent, and ensure golden corpus binary line-ending stability
There was a problem hiding this comment.
Code Review
This pull request introduces a canonical content hashing mechanism to handle line ending differences consistently across platforms and adds support for locating the TypeScript compiler (tsc) on Windows environments. While these improvements are valuable, the logic for resolving the tsc executable path and its associated imports is duplicated across five different test files, which also violates PEP 8 by placing imports in the middle of the files. It is highly recommended to centralize this path resolution logic into a shared utility module and import it at the top of each test file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Resolved in commit 0d13a60.
|
Problem
TypeScript compiler (
tsc) path resolution logic was duplicated across five different test files, violating PEP 8 by placing imports inside function blocks.Root cause
Lack of shared TypeScript compiler resolution helper utility.
Final changes
resolve_tsc_executable()insidetests/utils/__init__.py.Security impact
None. Improves codebase maintainability.
Compatibility impact
Supports resolving
tsc.cmdon Windows andtscon POSIX hosts, preferring localnode_modulesthen falling back to system PATH. Normalizes LF newlines for golden content checks (not byte identity).Tests
All 388 unit tests pass locally.
CI
0d13a604007f47c3dca29b389584662ee412820a: PASS (Analyze, CodeQL, agent-checks, and validation runs completed successfully).Review findings addressed
Independent verification
Checked and confirmed clean by the Antigravity Verification Agent.
CodeRabbit status
CODERABBIT_NOT_RUN_RUNTIME_SIGILL_WSL_CPU_INCOMPATIBILITYCodeRabbit CLI was installed successfully inside WSL 2 Ubuntu, but execution terminated with SIGILL because of CPU instruction-set compatibility in the current WSL environment. No CodeRabbit review result was produced.
Known limitations
None.
Rollback
Revert this pull request.
Evidence
tests/utils/__init__.py