Skip to content

fix(v7): resolve packaging, tsc path portability, and golden newline issues#219

Merged
ProfRandom92 merged 3 commits into
mainfrom
audit/p0-comptextv7-portability
Jul 21, 2026
Merged

fix(v7): resolve packaging, tsc path portability, and golden newline issues#219
ProfRandom92 merged 3 commits into
mainfrom
audit/p0-comptextv7-portability

Conversation

@ProfRandom92

@ProfRandom92 ProfRandom92 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Problem

TypeScript compiler (tsc) path resolution logic was duplicated across five different test files, violating PEP 8 by placing imports inside function blocks.

Root cause

Lack of shared TypeScript compiler resolution helper utility.

Final changes

  • Centralized path resolution in resolve_tsc_executable() inside tests/utils/__init__.py.
  • Replaced duplicate code blocks and imported the helper at the top level of the 5 test files.

Security impact

None. Improves codebase maintainability.

Compatibility impact

Supports resolving tsc.cmd on Windows and tsc on POSIX hosts, preferring local node_modules then falling back to system PATH. Normalizes LF newlines for golden content checks (not byte identity).

Tests

All 388 unit tests pass locally.

CI

  • CI checks at head 0d13a604007f47c3dca29b389584662ee412820a: PASS (Analyze, CodeQL, agent-checks, and validation runs completed successfully).

Review findings addressed

  • Resolved duplicate tsc path resolution logic across all 5 TypeScript integration test files.

Independent verification

Checked and confirmed clean by the Antigravity Verification Agent.

CodeRabbit status

CODERABBIT_NOT_RUN_RUNTIME_SIGILL_WSL_CPU_INCOMPATIBILITY

CodeRabbit CLI was installed successfully inside WSL 2 Ubuntu, but execution terminated with SIGILL because of CPU instruction-set compatibility in the current WSL environment. No CodeRabbit review result was produced.

Known limitations

None.

Rollback

Revert this pull request.

Evidence

  • tests/utils/__init__.py

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a canonical content hashing mechanism to handle line ending differences consistently across platforms and adds support for locating the TypeScript compiler (tsc) on Windows environments. While these improvements are valuable, the logic for resolving the tsc executable path and its associated imports is duplicated across five different test files, which also violates PEP 8 by placing imports in the middle of the files. It is highly recommended to centralize this path resolution logic into a shared utility module and import it at the top of each test file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/test_compression_signals_ts.py Outdated
Comment thread tests/test_core_foundation_ts.py Outdated
Comment thread tests/test_reference_index_event_fingerprints_ts.py Outdated
Comment thread tests/test_replay_artifact_writer_ts.py Outdated
Comment thread tests/test_shared_stable_hashing_ts.py Outdated
@ProfRandom92

Copy link
Copy Markdown
Owner Author

Resolved in commit 0d13a60.

  • Cause: The local TypeScript compiler path resolution logic was duplicated across five test files.
  • Fix: Centralized resolve_tsc_executable() in tests/utils/init.py and imported it at the top of the test files.
  • Tests: Run all 388 unit tests successfully.
  • CI Status: Running/Pending.

@ProfRandom92
ProfRandom92 marked this pull request as ready for review July 20, 2026 21:20
@ProfRandom92
ProfRandom92 merged commit 716d0e9 into main Jul 21, 2026
7 checks passed
@ProfRandom92
ProfRandom92 deleted the audit/p0-comptextv7-portability branch July 21, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant