You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches core task index SQL (filters, ordering, non-admin scoping); behavior should be equivalent but sort/join strategy changed, so edge cases in ordering or permissions merit regression testing.
Overview
Fixes ambiguous SQL column errors (e.g. user_id) when non-admin users list tasks with sort on related fields such as process_requests.case_title, including with PMQL and advanced filters.
Query changes in TaskControllerIndexMethods: Drops conditional LEFT JOINs on process_requests / users for ordering and instead sorts via a new relatedOrderSubquery correlated subquery for user name, request JSON data.*, and process_requests.* columns (token columns still use process_request_tokens.*). Fully qualifies token columns in filters and scoping (process_id, status, user_id, id in applyForCurrentUser).
Tests: Adds TaskListNonAdminCaseTitleOrderTest covering case-title DESC ordering for non-admins, with and without fulltext PMQL.
Reviewed by Cursor Bugbot for commit 4486e09. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Non-admin task lists sorted by case title hit an ambiguous user_id SQL error.
Solution
How to Test
Related Tickets & Packages
ci:deploy