Skip to content

FOUR-33374 Fix issue qualifing columns in queries - #9066

Merged
nolanpro merged 2 commits into
developfrom
FOUR-33374
Sep 18, 2026
Merged

nolanpro merged 2 commits into
developfrom
FOUR-33374

Conversation

@caleeli

@caleeli caleeli commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Non-admin task lists sorted by case title hit an ambiguous user_id SQL error.

Solution

  • Qualify columns.
  • Use subquery in sort by

How to Test

  • Login with a non admin user
  • Go to tasks
  • Sort by case_title
image

Related Tickets & Packages

ci:deploy

@cursor

cursor Bot commented Sep 18, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches core task index SQL (filters, ordering, non-admin scoping); behavior should be equivalent but sort/join strategy changed, so edge cases in ordering or permissions merit regression testing.

Overview
Fixes ambiguous SQL column errors (e.g. user_id) when non-admin users list tasks with sort on related fields such as process_requests.case_title, including with PMQL and advanced filters.

Query changes in TaskControllerIndexMethods: Drops conditional LEFT JOINs on process_requests / users for ordering and instead sorts via a new relatedOrderSubquery correlated subquery for user name, request JSON data.*, and process_requests.* columns (token columns still use process_request_tokens.*). Fully qualifies token columns in filters and scoping (process_id, status, user_id, id in applyForCurrentUser).

Tests: Adds TaskListNonAdminCaseTitleOrderTest covering case-title DESC ordering for non-admins, with and without fulltext PMQL.

Reviewed by Cursor Bugbot for commit 4486e09. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

@nolanpro
nolanpro merged commit 3159b63 into develop Sep 18, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants