Skip to content

FOUR-33304 Fix Vite Errors - #9065

Merged
nolanpro merged 10 commits into
developfrom
task/FOUR-33304
Sep 18, 2026
Merged

nolanpro merged 10 commits into
developfrom
task/FOUR-33304

Conversation

@nolanpro

@nolanpro nolanpro commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

https://processmaker.atlassian.net/browse/FOUR-33304
ci:modeler:task/FOUR-33304
ci:deploy
ci:use-packagist-branches
ci:k8s-branch:task/FOUR-33304

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches modeler load order, static asset paths, and multiplayer gating—regressions would show as broken modeler UI or missing package scripts rather than backend data issues.

Overview
Hardens the Vite/Mix front-end pipeline so the process modeler and other ESM entry points load without runtime/build failures (FOUR-33304).

The modeler boot path is reworked: a new globals.js Vite entry puts inspector/shared/process components on window (replacing side-effect library imports in loaderModeler.js), multiplayer settings are normalized in JS and emitted from Blade as real booleans/null instead of string config, and package scripts are passed as modelerPackageScripts (excluding initialLoad) with explicit type="module" vs deferred classic tags. vite.config.js adds vite-plugin-static-copy with stripBase for Monaco, images, modeler SVGs, and BPMN fonts; a lodash inject plugin and bootstrap-globals.js mirror Webpack’s ProvidePlugin for bare _ usage; rollup treeshake sideEffects keep global-registration modules from being dropped.

Script boilerplate moves from Vue filters to exported formatScriptBoilerplate helpers used by ScriptEditor.vue. Screen-builder typeForm/typeDisplay stay on Mix only; those @vite tags are removed from screen/request preview blades. Launchpad ProcessScreen.vue drops the wizard helper modal and related props/events. league/commonmark is bumped to ^2.10 in Composer.

Reviewed by Cursor Bugbot for commit c9a3928. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ac654ac. Configure here.

Comment thread vite.config.js
@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

1 similar comment
@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

1 similar comment
@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-59c7e4ffa0.engk8s.processmaker.net

@nolanpro
nolanpro merged commit 7392520 into develop Sep 18, 2026
20 of 27 checks passed
@nolanpro
nolanpro deleted the task/FOUR-33304 branch September 18, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants