test: cover getUpstashConfig missing-env and empty-string cases (#3031)#3192
test: cover getUpstashConfig missing-env and empty-string cases (#3031)#3192aaniya22 wants to merge 2 commits into
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
The test cases themselves are correct and useful, but they're added to |
Summary
Adds test coverage for
getUpstashConfig()'s two untested branches — both env vars set, and either env var being an empty string — closing the gap identified in the issue.Closes #3031
Type of Change
What Changed
getUpstashConfig returns { url, token } when both env vars are settotest/upstash-rest.test.mjsgetUpstashConfig returns null when either env var is an empty stringtotest/upstash-rest.test.mjssrc/lib/upstash-rest.tsitself — test-only PRHow to Test
node --test test/upstash-rest.test.mjsExpected result: All tests pass, including the two new cases covering
getUpstashConfig's previously-untested branches.Screenshots / Recordings
Not applicable — test-only change, no UI impact.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Not applicable — no UI impact.
Additional Context
Issue #3031 asked for a new
test/upstash-rest.test.tsusing Vitest, but atest/upstash-rest.test.mjsusing Node's built-innode:testrunner already exists and covers most ofupstash-rest.ts(includingupstashRateLimitFixedWindowandupstashTryAcquireLock). Rather than create a second, competing test file for the same module in a different framework, I extended the existing file with the two specificgetUpstashConfigscenarios the issue called out that weren't yet covered. Happy to convert to a standalone Vitest file instead if that's preferred — just let me know and I'll follow up.