Fix pc/1.21.11 attribute_modifiers entry shape - #1253
Open
extremeheat with Copilot wants to merge 2 commits into
Open
Fix pc/1.21.11 attribute_modifiers entry shape#1253extremeheat with Copilot wants to merge 2 commits into
extremeheat with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix attribute_modifiers display issue in pc/1.21.11
Fix pc/1.21.11 attribute_modifiers entry shape
Aug 17, 2026
fitzzero
approved these changes
Aug 20, 2026
extremeheat
marked this pull request as ready for review
August 21, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pc/1.21.11encodedattribute_modifiersdifferently from adjacent versions:displaywas attached once after the list instead of per modifier entry. That breaks decoding for items carrying 2+ explicit modifiers because subsequent entries are read at the wrong offset.Protocol shape
data/pc/1.21.11/proto.ymlsoattribute_modifiersis an array of entry containers, withdisplaynested inside each entry.data/pc/1.21.11/protocol.jsonfrom the YAML source.Regression coverage
1.21.11SlotComponent.attribute_modifiersshape matches the neighboring per-entry layout used by1.21.9.