test: enforce metadataKeys presence in pc entities 1.19.4+ - #1241
Open
AnonymoDGH wants to merge 2 commits into
Open
test: enforce metadataKeys presence in pc entities 1.19.4+#1241AnonymoDGH wants to merge 2 commits into
AnonymoDGH wants to merge 2 commits into
Conversation
AnonymoDGH
force-pushed
the
fix/mcd-1058
branch
from
August 16, 2026 09:38
d3b6ca2 to
6c5c1b9
Compare
AnonymoDGH
force-pushed
the
fix/mcd-1058
branch
from
August 16, 2026 09:43
6c5c1b9 to
3cb423e
Compare
Member
|
Good idea, but we should also probably add this generation step to the current new version automation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058
Adds an automated audit test that enforces the presence of the
metadataKeyskey inentities.jsonfor all PC versions from 1.19.4 onward, as suggested in the mineflayer PR comment.Verified: 127 tests pass; all current PC entities 1.19.4+ already have metadataKeys.