[fix] [v1]: reject dupe artifact sources - #2225
Open
gtnv wants to merge 2 commits into
Open
Conversation
Reject duplicate post-workdir artifact sources before collection so each budget charge maps to one returned archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prev: archive and charge every declaration before dict kept only last value.
Now: duplicate artifact declarations are resolved before colection
closes: #2198
Note
Low Risk
Small validation-only change in artifact collection; the only behavioral shift is failing fast on misconfigured duplicate sources instead of silent overwrite.
Overview
collectnow validates the resolvedentrieslist before tarring anything: it tracksartifact.sourcevalues and raisesRuntimeErrorif the same source appears twice.That replaces the previous behavior where duplicate declarations still ran collection and the returned dict silently kept only the last entry per key—aligning runtime behavior with the existing docstring that a path cannot be collected twice.
Reviewed by Cursor Bugbot for commit a2f9abc. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Reject duplicate artifact sources in
collectAdds a pre-collection validation step in
collectthat tracks seenartifact.sourcevalues and raises aRuntimeErrorif any source appears more than once. Risk: existing callers with duplicate artifact sources will now fail at runtime instead of silently collecting duplicates.Macroscope summarized a2f9abc.