Conversation
Every directory except lib links ../lib/libcom.a, but the top-level Makefile declared no dependency between the sub-directory targets, so a parallel top-level build (make -j8) started them all at once and utils, orbit, tedit, lsq, redig and arsig failed with "No rule to make target ../lib/libcom.a". install.sh runs a serial make and was not affected. Declaring that every other directory depends on lib restores the ordering while keeping the per-directory builds parallel. Verified with a clean make -j8 on Ubuntu 24.04 (gfortran 13) and on macOS (Darwin 27, Homebrew gfortran 16): all 11 executables build.
smyrgl
marked this pull request as ready for review
September 16, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Running
make -jNinsrc/starts the sub-directories concurrently. Every directory exceptliblinks../lib/libcom.a, but the top-level Makefile declares no dependency between the sub-directory targets, so withmake -j8six of them fail beforelibhas finished:install.shruns a serialmake, so the documented install path is not affected; this only bites people building by hand or in CI.Fix: One dependency line: every other directory depends on
lib. The per-directorymake -j4stays parallel.Verified: Clean
make -j8followed bymake installon Ubuntu 24.04 (gfortran 13.3, about 5 s wall) and on macOS (Homebrew gfortran 16): all 11 executables build. A serialmakebehaves as before.