Skip to content

feat: implement export filter functionality for resource exports#1621

Open
Gijsreyn wants to merge 7 commits into
PowerShell:mainfrom
Gijsreyn:gh-1486/main/add-postfilter-export
Open

feat: implement export filter functionality for resource exports#1621
Gijsreyn wants to merge 7 commits into
PowerShell:mainfrom
Gijsreyn:gh-1486/main/add-postfilter-export

Conversation

@Gijsreyn

Copy link
Copy Markdown
Collaborator

PR Summary

Adds engine-side post-filtering for export via a new exportFilter resource directive.

PR Context

Fixes #1486.

Copilot AI review requested due to automatic review settings July 11, 2026 13:18
@Gijsreyn Gijsreyn force-pushed the gh-1486/main/add-postfilter-export branch from ba1baec to 664abad Compare July 11, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements engine-side post-filtering for dsc config export results via a new exportFilter resource directive, enabling consistent wildcard/equality filtering even for resources that don’t implement native export filtering.

Changes:

  • Adds exportFilter to the configuration resource directives schema and applies it in the export pipeline after resource.export(...).
  • Introduces configure::export_filter matching logic (case-insensitive * wildcard for strings; OR across filter objects, AND within each object) plus unit tests.
  • Adds Pester coverage for exportFilter behavior and updates the dsctest export resource to emit a name property for filtering.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/dsctest/src/main.rs Emits per-instance name values to enable filter-driven tests.
tools/dsctest/src/export.rs Extends the test export payload schema with optional name.
lib/dsc-lib/src/dscresources/command_resource.rs Adjusts when “export filtering not supported” is raised (only for non-empty input).
lib/dsc-lib/src/configure/mod.rs Wires exportFilter from directives into the export pipeline.
lib/dsc-lib/src/configure/export_filter.rs Adds the engine-side filtering implementation + Rust unit tests.
lib/dsc-lib/src/configure/config_doc.rs Adds export_filter directive field to the config document model/schema.
lib/dsc-lib/locales/en-us.toml Adds localized message for filter reduction logging.
dsc/tests/dsc_export.tests.ps1 Adds integration tests validating exportFilter behavior across scenarios.
dsc/src/resource_command.rs Updates call site for the changed export helper function signature.

Comment thread lib/dsc-lib/src/configure/mod.rs Outdated
Comment thread lib/dsc-lib/src/configure/export_filter.rs Outdated
Comment thread lib/dsc-lib/src/configure/export_filter.rs Outdated
@Gijsreyn Gijsreyn requested a review from SteveL-MSFT July 12, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow post-filtering for export

2 participants